Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parsing): fix git url parsing #195

Merged
merged 29 commits into from
Jan 8, 2024
Merged

fix(parsing): fix git url parsing #195

merged 29 commits into from
Jan 8, 2024

Conversation

linrongbin16
Copy link
Owner

@linrongbin16 linrongbin16 commented Jan 8, 2024

Fix #193 , relate PR: #187 .

The major work is done at a library: https://github.com/linrongbin16/giturlparser.lua, here just use the library.

Regression Test

Platforms

  • windows
  • macOS
  • linux

Hosts

Functions

  • Use GitLink to copy git link.
  • Use GitLink! to open git link in browser.
  • Use GitLink blame to copy the /blame git link.
  • Use GitLink! blame to open the /blame git link in browser.
  • Copy git link in a symlink directory of git repo.
  • Copy git link in an un-pushed git branch, and receive an expected error.
  • Copy git link in a pushed git branch but edited file, and receive a warning says the git link could be wrong.

@github-actions github-actions bot added the fix label Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (c6aaef1) 64.48% compared to head (eb18e97) 66.85%.

Files Patch % Lines
lua/gitlinker/linker.lua 8.33% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   64.48%   66.85%   +2.37%     
==========================================
  Files           7        7              
  Lines         794      706      -88     
==========================================
- Hits          512      472      -40     
+ Misses        282      234      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linrongbin16 linrongbin16 merged commit ab44bb7 into master Jan 8, 2024
9 checks passed
@linrongbin16 linrongbin16 deleted the fix-git-url-parsing branch January 8, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL Parsing Failure Issue
1 participant